pnowojski commented on a change in pull request #18991:
URL: https://github.com/apache/flink/pull/18991#discussion_r827994494
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
##########
@@ -1763,6 +1765,108 @@ public long calculateThroughput() {
}
}
+ /**
+ * Tests mailbox metrics latency and queue size and verifies that (1)
latency measurement is
+ * executed initially once and at least once triggered by timer, (2)
latency max value is
+ * greater than zero and (3) mailbox size is greater than zero for some
time and eventually
+ * equals to zero.
+ *
+ * <p>Note: This test uses a timeout which, if exceeded, indicates that
the minimum number of
+ * latency measurements has not reached the specified minimum within
specified time.
+ *
+ * @throws Exception on {@link MockEnvironmentBuilder#build()} failure.
+ */
+ @Test(timeout = 4000)
Review comment:
I would remove this timeout. Our general best practise (learnt the hard
way) is to avoid timeouts inside the tests. If there is a deadlock/livelock,
it's actually better for mvn watchdog to detect that, and kill the build with
printing thread dump.
Apart of that 4s is most likely too short. We have seen occasional 10-15sec
freezes in the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
