[
https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428249#comment-15428249
]
ASF GitHub Bot commented on FLINK-4329:
---------------------------------------
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2350
I made one inline comments about moving the `SourceContext` and the
instantiation code.
Also, the problem with the "async exception check" can be solved by
introducing an interface `AsyncExceptionChecker` that is passed to the context.
(I think that's what @rmetzger was hinting at.)
Even better yet, we might be able to get rid of that stuff by using
`task.failExternally()` in all places that previously made these async checks
necessary. (The file read operator already uses that, btw)
> Fix Streaming File Source Timestamps/Watermarks Handling
> --------------------------------------------------------
>
> Key: FLINK-4329
> URL: https://issues.apache.org/jira/browse/FLINK-4329
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
> Affects Versions: 1.1.0
> Reporter: Aljoscha Krettek
> Assignee: Kostas Kloudas
> Fix For: 1.1.1
>
>
> The {{ContinuousFileReaderOperator}} does not correctly deal with watermarks,
> i.e. they are just passed through. This means that when the
> {{ContinuousFileMonitoringFunction}} closes and emits a {{Long.MAX_VALUE}}
> that watermark can "overtake" the records that are to be emitted in the
> {{ContinuousFileReaderOperator}}. Together with the new "allowed lateness"
> setting in window operator this can lead to elements being dropped as late.
> Also, {{ContinuousFileReaderOperator}} does not correctly assign ingestion
> timestamps since it is not technically a source but looks like one to the
> user.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
