Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2350#discussion_r75488070
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -103,12 +103,28 @@ public void open() throws Exception {
this.format.setRuntimeContext(getRuntimeContext());
this.format.configure(new Configuration());
- this.collector = new TimestampedCollector<>(output);
this.checkpointLock = getContainingTask().getCheckpointLock();
Preconditions.checkState(reader == null, "The reader is already
initialized.");
- this.reader = new SplitReader<>(format, serializer, collector,
checkpointLock, readerState);
+ // set the reader context based on the time characteristic
--- End diff --
I think both the `SourceContext` plus subclasses and this instantiation
code should be moved out of the sources since it is now used for more than
that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
