imaffe commented on a change in pull request #18345:
URL: https://github.com/apache/flink/pull/18345#discussion_r829777664
##########
File path:
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/cursor/StopCursor.java
##########
@@ -71,7 +71,7 @@ static StopCursor afterMessageId(MessageId messageId) {
return new MessageIdStopCursor(messageId, false);
}
- static StopCursor atEventTime(long timestamp) {
+ static StopCursor atPublishTime(long timestamp) {
Review comment:
I searched and found something: "All method declarations in an
interface, including static methods, are implicitly public, so you can omit the
public modifier. "
https://docs.oracle.com/javase/tutorial/java/IandI/defaultmethods.html#static
So here users can use these static members.
On the other hand, in general we recommend atPublishTime. I'll delete the
documentation for atEventTime().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
