imaffe commented on a change in pull request #18345:
URL: https://github.com/apache/flink/pull/18345#discussion_r829818505
##########
File path:
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/cursor/StopCursor.java
##########
@@ -71,7 +71,7 @@ static StopCursor afterMessageId(MessageId messageId) {
return new MessageIdStopCursor(messageId, false);
}
- static StopCursor atEventTime(long timestamp) {
+ static StopCursor atPublishTime(long timestamp) {
Review comment:
> > One thing left is that, pyflink has Pulsar connector support, but I
don't know if that file is auto-generated or maintained by developers.
> > flink-python/pyflink/datastream/connectors.py
>
> Unfortunately, it is not auto generated and manually maintained but I
cannot really help with the python side.
I've added the java doc~ For python connector, I'll leave it intact and
see what's our plan of updating the python connector. I think it' likely we can
do a major upgrade after small fixes accumulates to a certain amount.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
