RyanSkraba commented on a change in pull request #19161:
URL: https://github.com/apache/flink/pull/19161#discussion_r830231696
##########
File path:
flink-formats/flink-avro-confluent-registry/src/test/java/org/apache/flink/formats/avro/registry/confluent/CachedSchemaCoderProviderTest.java
##########
@@ -22,7 +22,7 @@
import io.confluent.kafka.schemaregistry.client.rest.RestService;
import
io.confluent.kafka.schemaregistry.client.security.basicauth.BasicAuthCredentialProvider;
import
io.confluent.kafka.schemaregistry.client.security.bearerauth.BearerAuthCredentialProvider;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import org.powermock.reflect.Whitebox;
Review comment:
It's tricky to get rid of this `Whitebox` ... I left it for now.
I'm thinking the best alternative might actually be to remove a bunch of
these tests: SSL setup is tested extensively internally to the Confluent Schema
Registry. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
