zentol commented on a change in pull request #19161:
URL: https://github.com/apache/flink/pull/19161#discussion_r832154253
##########
File path:
flink-formats/flink-avro-confluent-registry/src/test/java/org/apache/flink/formats/avro/registry/confluent/CachedSchemaCoderProviderTest.java
##########
@@ -22,7 +22,7 @@
import io.confluent.kafka.schemaregistry.client.rest.RestService;
import
io.confluent.kafka.schemaregistry.client.security.basicauth.BasicAuthCredentialProvider;
import
io.confluent.kafka.schemaregistry.client.security.bearerauth.BearerAuthCredentialProvider;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import org.powermock.reflect.Whitebox;
Review comment:
As is the tests don't provide any value; but if we refactored them to
actually use the Flink factories (_actually_ checking that the right properties
are set) then we'd still need the Whitebox for verification I suppose.
I'd leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
