matriv commented on a change in pull request #19187:
URL: https://github.com/apache/flink/pull/19187#discussion_r831182593
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/abilities/source/WatermarkPushDownSpec.java
##########
@@ -75,15 +74,15 @@ public void apply(DynamicTableSource tableSource,
SourceAbilityContext context)
if (tableSource instanceof SupportsWatermarkPushDown) {
GeneratedWatermarkGenerator generatedWatermarkGenerator =
WatermarkGeneratorCodeGenerator.generateWatermarkGenerator(
- context.getTableConfig().getConfiguration(),
+ context.getTableConfig(),
context.getSourceRowType(),
watermarkExpr,
Option.apply("context"));
- Configuration configuration =
context.getTableConfig().getConfiguration();
WatermarkGeneratorSupplier<RowData> supplier =
new GeneratedWatermarkGeneratorSupplier(
- configuration, generatedWatermarkGenerator);
+ context.getTableConfig().getConfiguration(),
Review comment:
Currently no, because `WatermarkGenerator` implements
`AbstrachRichFunction` for which the `open()` method has the following
signature:
```public void open(Configuration parameters) throws Exception {}```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
