yunfengzhou-hub commented on a change in pull request #70: URL: https://github.com/apache/flink-ml/pull/70#discussion_r832001871
########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/clustering/kmeans/OnlineKMeans.java ########## @@ -0,0 +1,409 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.clustering.kmeans; Review comment: I think keeping `OnlineKMeans` in `kmeans` package is more suitable. Because - I hardly feel that `OnlineKMeans` and `KMeans` are not different algorithms. They are the same algorithm with different external condition. - In implementation, `OnlineKMeans` and `KMeans` have exclusively shared some infra codes, like `KMeansModelData`, `KMeansParams` and `findClosestCentroidId`. If they are put into different packages, I am worried that there will be high cohesion between `kmeans` and onlinekmeans` packages. The reasons above are not definitive and I would still be glad to make the change if we have other more important reasons. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
