yunfengzhou-hub commented on a change in pull request #70: URL: https://github.com/apache/flink-ml/pull/70#discussion_r832099135
########## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/util/MockKVStore.java ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.util; + +import java.util.HashMap; +import java.util.Map; + +/** Class that manages global key-value pairs used in unit tests. */ +@SuppressWarnings({"unchecked"}) +public class MockKVStore { + private static final Map<String, Object> map = new HashMap<>(); + + private static long counter = 0; + + /** + * Returns a prefix string to make sure key-value pairs created in different test cases would + * not have the same key. + */ + public static synchronized String createNonDuplicatePrefix() { Review comment: Got it. As we are using InMemoryReporter and thus won't be able to implement this in MockKVStore, I'll apply this principle to the design of simplified test blocking queue mechanisms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
