FilKarnicki opened a new pull request #309:
URL: https://github.com/apache/flink-statefun/pull/309
# What is the purpose of the change
The goal of this PR is to add the ability to define ${placeholders} in the
module.yaml's `spec` object, e.g.:
```yaml
kind: com.foo.bar/test
spec:
something: ${REPLACE_ME}
transport:
password: ${REPLACE_ME_WITH_A_SECRET}
array:
- ${REPLACE_ME}
- sthElse
```
These placeholders are then replaced using
1. System properties
2. Environment variables
3. flink-conf.yaml entries with prefix 'statefun.module.global-config.'
4. Command line args
where (4) override (3) which override (2) which override (1).
# Main changes are
- `RemoteModule` resolves placeholders by traversing through the `spec` json
node
- `ComponentJsonObject` has a new constructor that allows the use of
resolved `spec` json node (note: `rawObjectNode` still contains unresolved
${placeholders}, but does not seem to be used anywhere)
# Verifying this change
- Added tests for resolving placeholders, and a test for a value that is
not found in the combined key-value config map, where an
IllegalArgumentException is thrown.
- Updated Java, Go, and JS e2e tests to use placeholders
---
Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @public(Evolving):
N/A
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
