LadyForest commented on a change in pull request #57:
URL: https://github.com/apache/flink-table-store/pull/57#discussion_r833052419
##########
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java
##########
@@ -93,17 +93,22 @@ public Boundedness getBoundedness() {
read.withDropDelete(false);
}
+ int[][] valueCountProject = null;
if (projectedFields != null) {
if (valueCountMode) {
- // TODO when isContinuous is false, don't project keys, and
add key projection to
- // split reader
- read.withKeyProjection(projectedFields);
+ // when isContinuous is false, don't project keys, otherwise,
there is no way to
Review comment:
Nit: personally, I think the current comment is not so straightforward.
What about "push projection to file store for better performance under
continuous read mode, because the merge cannot be performed anyway"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
