LadyForest commented on a change in pull request #57:
URL: https://github.com/apache/flink-table-store/pull/57#discussion_r833081896
##########
File path:
flink-table-store-kafka/src/main/java/org/apache/flink/table/store/kafka/KafkaLogDeserializationSchema.java
##########
@@ -85,22 +101,50 @@ public RowData deserialize(ConsumerRecord<byte[], byte[]>
record) {
}
@Override
- public void deserialize(ConsumerRecord<byte[], byte[]> record,
Collector<RowData> out)
+ public void deserialize(
+ ConsumerRecord<byte[], byte[]> record, Collector<RowData>
underCollector)
Review comment:
what's the point of renaming `out` to `underCollector`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
