[
https://issues.apache.org/jira/browse/FLINK-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430899#comment-15430899
]
ASF GitHub Bot commented on FLINK-4443:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2401
Thanks for your contribution @wenlong88. Your changes look good to me. I
only had a comment concerning the `NativeMethod` annotation. I think that at
the moment we could get along without it by considering all `RpcGateway`
methods implicitly native. That would simplify decrease the complexity a little
bit because we can get rid of/not introduce another annotation. What do you
think?
> Add support in RpcCompletenessTest for inheritance of RpcGateway and
> RpcEndpoint
> --------------------------------------------------------------------------------
>
> Key: FLINK-4443
> URL: https://issues.apache.org/jira/browse/FLINK-4443
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Wenlong Lyu
> Assignee: Wenlong Lyu
>
> RpcCompletenessTest needs to support RpcGateway which is composited by some
> basic functions like the example following:
> {code:java}
> public interface ExecutionStateListener extends RpcGateway {
> public void notifyExecutionStateChanges();
> }
> public interface JobStateListener extends RpcGateway {
> public void notifyJobStateChanges();
> }
> public interface JobWatcher extends ExecutionStateListener, JobStateListener,
> RpcGateway {
> }
> public class JobWatcherEndpoint extends RpcEndpoint<JobWatcher> {
> protected JobWatcherEndpoint(RpcService rpcService) {
> super(rpcService);
> }
> @RpcMethod
> public void notifyExecutionStateChanges() {
> }
> @RpcMethod
> public void notifyJobStateChanges() {
> }
> }
> public class AttachedJobClient extends JobWatcherEndpoint {
> protected JobClient(RpcService rpcService) {
> super(rpcService);
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
