[
https://issues.apache.org/jira/browse/FLINK-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434044#comment-15434044
]
ASF GitHub Bot commented on FLINK-4443:
---------------------------------------
GitHub user wenlong88 reopened a pull request:
https://github.com/apache/flink/pull/2401
[FLINK-4443][rpc] Add support in RpcCompletenessTest for inheritance of
RpcGateway and RpcEndpoint
RpcCompletenessTest needs to support RpcGateway which is composited by some
basic functions like following:
```
public interface ExecutionStateListener extends RpcGateway {
public void notifyExecutionStateChanges();
}
public interface JobStateListener extends RpcGateway {
public void notifyJobStateChanges();
}
public interface JobWatcher extends ExecutionStateListener,
JobStateListener, RpcGateway {
}
public class JobWatcherEndpoint extends RpcEndpoint<JobWatcher> {
protected JobWatcherEndpoint(RpcService rpcService) {
super(rpcService);
}
@RpcMethod
public void notifyExecutionStateChanges() {
}
@RpcMethod
public void notifyJobStateChanges() {
}
}
public class AttachedJobClient extends JobWatcherEndpoint {
protected JobClient(RpcService rpcService) {
super(rpcService);
}
}
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alibaba/flink flink-4443
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2401.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2401
----
commit 83b46df346d3626aa15f690c449d17fe3218014e
Author: wenlong.lwl <[email protected]>
Date: 2016-08-20T16:46:51Z
add support for rpc gateway and rpc endpoint inheritance
commit b471bd249fbc40a23c6d32e5840c5ab95d693f75
Author: wenlong.lwl <[email protected]>
Date: 2016-08-22T05:33:33Z
update comments
commit dc9d435f7bd732b5f75e228e65ffcad278e3d28b
Author: wenlong.lwl <[email protected]>
Date: 2016-08-23T01:53:31Z
remove native method annotation
commit 37b4f01b4c207ace518b3af842c015537a183e55
Author: wenlong.lwl <[email protected]>
Date: 2016-08-23T02:46:28Z
add line break
----
> Add support in RpcCompletenessTest for inheritance of RpcGateway and
> RpcEndpoint
> --------------------------------------------------------------------------------
>
> Key: FLINK-4443
> URL: https://issues.apache.org/jira/browse/FLINK-4443
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Wenlong Lyu
> Assignee: Wenlong Lyu
>
> RpcCompletenessTest needs to support RpcGateway which is composited by some
> basic functions like the example following:
> {code:java}
> public interface ExecutionStateListener extends RpcGateway {
> public void notifyExecutionStateChanges();
> }
> public interface JobStateListener extends RpcGateway {
> public void notifyJobStateChanges();
> }
> public interface JobWatcher extends ExecutionStateListener, JobStateListener,
> RpcGateway {
> }
> public class JobWatcherEndpoint extends RpcEndpoint<JobWatcher> {
> protected JobWatcherEndpoint(RpcService rpcService) {
> super(rpcService);
> }
> @RpcMethod
> public void notifyExecutionStateChanges() {
> }
> @RpcMethod
> public void notifyJobStateChanges() {
> }
> }
> public class AttachedJobClient extends JobWatcherEndpoint {
> protected JobClient(RpcService rpcService) {
> super(rpcService);
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
