[
https://issues.apache.org/jira/browse/FLINK-26892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513858#comment-17513858
]
Biao Geng commented on FLINK-26892:
-----------------------------------
Hi [~gyfora], I see your point.
The reason for I asking above question first is that I did some experiments and
found the wrong config would not affect the deployment. Later I found it is
because that I enabled webhook check, which would do a check first.
I removed the webhook and applied some wrong config (e.g. JM replica = -1) and
our {{reconcile() }} is stuck on the error. Your proposed solution is necessary
for those who do not enable webhook check.
> Observe current status before validating CR changes
> ---------------------------------------------------
>
> Key: FLINK-26892
> URL: https://issues.apache.org/jira/browse/FLINK-26892
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
> Reporter: Gyula Fora
> Priority: Major
> Fix For: kubernetes-operator-1.0.0
>
>
> Currently validation is the first step in the controller loop which means
> that when there is a validation error we fail to observe the status of
> currently running deployments.
> We should change the order of operations and observe before validation.
> Furthermore observe should use the previous configuration not the one after
> the CR change.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
