pnowojski commented on pull request #19219: URL: https://github.com/apache/flink/pull/19219#issuecomment-1084222368
I'm not so sure that the performance impact of `ConcurrentHashMap` won't be visible. And this change is on the performance sensitive per-record code path. I would like to first understand why has this concurrent modification happened and if we can simply avoid it. This code should be not-thread safe for the sake of simplicity. > I track all the usages of subclassSerializerCache, I can not find out the reason. I gess the subclassSerializerCache.entrySet().stream() is to blame. But what are the two threads that are touching the same serialiser instance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
