slinkydeveloper commented on a change in pull request #19190:
URL: https://github.com/apache/flink/pull/19190#discussion_r839373371
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/CallContext.java
##########
@@ -93,6 +93,17 @@ default ValidationException newValidationError(String
message, Object... args) {
return new ValidationException(String.format(message, args));
}
+ /**
+ * Shorthand for {@code if (throwOnFailure) throw ValidationException(...)
else return
Review comment:
TBH I wasn't sure where to place it, I placed it here as it's related to
`newValidationError`. TBH I would rather remove `newValidationError` at some
point, in order to force users to always use this method instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]