slinkydeveloper commented on a change in pull request #19190:
URL: https://github.com/apache/flink/pull/19190#discussion_r839393613
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java
##########
@@ -1222,76 +1231,103 @@
BuiltInFunctionDefinition.newBuilder()
.name("extract")
.kind(SCALAR)
- .outputTypeStrategy(TypeStrategies.MISSING)
+ .inputTypeStrategy(SpecificInputTypeStrategies.EXTRACT)
+ .outputTypeStrategy(explicit(BIGINT().notNull()))
.build();
public static final BuiltInFunctionDefinition CURRENT_DATE =
BuiltInFunctionDefinition.newBuilder()
.name("currentDate")
.kind(SCALAR)
- .outputTypeStrategy(TypeStrategies.MISSING)
+ .outputTypeStrategy(explicit(DATE().notNull()))
.build();
public static final BuiltInFunctionDefinition CURRENT_TIME =
BuiltInFunctionDefinition.newBuilder()
.name("currentTime")
.kind(SCALAR)
- .outputTypeStrategy(TypeStrategies.MISSING)
+ .outputTypeStrategy(explicit(TIME().notNull()))
.build();
public static final BuiltInFunctionDefinition CURRENT_TIMESTAMP =
BuiltInFunctionDefinition.newBuilder()
.name("currentTimestamp")
.kind(SCALAR)
- .outputTypeStrategy(TypeStrategies.MISSING)
+ .outputTypeStrategy(explicit(TIMESTAMP_LTZ(3).notNull()))
.build();
public static final BuiltInFunctionDefinition CURRENT_ROW_TIMESTAMP =
BuiltInFunctionDefinition.newBuilder()
.name("currentRowTimestamp")
.kind(SCALAR)
- .outputTypeStrategy(TypeStrategies.MISSING)
+ .outputTypeStrategy(explicit(TIMESTAMP_LTZ(3).notNull()))
.build();
public static final BuiltInFunctionDefinition LOCAL_TIME =
BuiltInFunctionDefinition.newBuilder()
.name("localTime")
.kind(SCALAR)
- .outputTypeStrategy(TypeStrategies.MISSING)
+ .outputTypeStrategy(explicit(TIME().notNull()))
.build();
public static final BuiltInFunctionDefinition LOCAL_TIMESTAMP =
BuiltInFunctionDefinition.newBuilder()
.name("localTimestamp")
.kind(SCALAR)
- .outputTypeStrategy(TypeStrategies.MISSING)
+ .outputTypeStrategy(explicit(TIMESTAMP(3).notNull()))
.build();
public static final BuiltInFunctionDefinition TEMPORAL_OVERLAPS =
BuiltInFunctionDefinition.newBuilder()
.name("temporalOverlaps")
.kind(SCALAR)
- .outputTypeStrategy(TypeStrategies.MISSING)
+
.inputTypeStrategy(SpecificInputTypeStrategies.TEMPORAL_OVERLAPS)
+ .outputTypeStrategy(explicit(BOOLEAN().notNull()))
.build();
public static final BuiltInFunctionDefinition DATE_FORMAT =
BuiltInFunctionDefinition.newBuilder()
.name("dateFormat")
.kind(SCALAR)
- .outputTypeStrategy(TypeStrategies.MISSING)
+ .inputTypeStrategy(
+ or(
+ sequence(
+
logical(LogicalTypeFamily.TIMESTAMP),
+
logical(LogicalTypeFamily.CHARACTER_STRING)),
+ sequence(
+
logical(LogicalTypeFamily.CHARACTER_STRING),
+
logical(LogicalTypeFamily.CHARACTER_STRING))))
+ .outputTypeStrategy(explicit(STRING().notNull()))
.build();
public static final BuiltInFunctionDefinition TIMESTAMP_DIFF =
BuiltInFunctionDefinition.newBuilder()
.name("timestampDiff")
.kind(SCALAR)
- .outputTypeStrategy(TypeStrategies.MISSING)
+ .inputTypeStrategy(
+ sequence(
+ symbol(
+ TimePointUnit.YEAR,
+ TimePointUnit.QUARTER,
+ TimePointUnit.MONTH,
+ TimePointUnit.WEEK,
+ TimePointUnit.DAY,
+ TimePointUnit.HOUR,
+ TimePointUnit.MINUTE,
+ TimePointUnit.SECOND),
+ logical(LogicalTypeFamily.DATETIME),
+ logical(LogicalTypeFamily.DATETIME)))
+ .outputTypeStrategy(explicit(INT()))
.build();
public static final BuiltInFunctionDefinition TO_TIMESTAMP_LTZ =
BuiltInFunctionDefinition.newBuilder()
.name("toTimestampLtz")
.kind(SCALAR)
- .outputTypeStrategy(TypeStrategies.MISSING)
+ .inputTypeStrategy(
+ sequence(
+ logical(LogicalTypeFamily.NUMERIC),
Review comment:
The `TIMESTAMP_LTZ` takes two params, the value of the timestamp can be
a generic numeric which can be casted, while the precision must be an integer
numeric. The reason for nullability is that we say that `TO_TIMESTAMP_LTZ`
allows null values, and can return null values, while the precision must always
be non-null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
