tsreaper commented on a change in pull request #70:
URL: https://github.com/apache/flink-table-store/pull/70#discussion_r840271261
##########
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/UniversalCompaction.java
##########
@@ -63,7 +63,8 @@ public UniversalCompaction(int maxSizeAmp, int sizeRatio, int
maxRunNum) {
// 3 checking for file num
if (runs.size() > maxRunNum) {
Review comment:
Trigger number for this compaction and other compactions should be
different (see [rocksdb
wiki](https://github.com/facebook/rocksdb/wiki/Universal-Compaction#4-compaction-triggered-by-number-of-sorted-runs-without-respecting-size_ratio)).
Add a new option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
