wangyang0918 commented on code in PR #141:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/141#discussion_r843719771
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/FlinkResourceValidator.java:
##########
@@ -17,19 +17,20 @@
package org.apache.flink.kubernetes.operator.validation;
+import org.apache.flink.core.plugin.Plugin;
import org.apache.flink.kubernetes.operator.crd.FlinkDeployment;
import org.apache.flink.kubernetes.operator.crd.FlinkSessionJob;
import java.util.Optional;
/** Validator for different resources. */
-public interface FlinkResourceValidator {
+public interface FlinkResourceValidator extends Plugin {
/**
* Validate and return optional error.
*
- * @param deployment
- * @return Optional error string, should be present iff validation
resulted in an error
+ * @param deployment A Flink application or session cluster deployment.
+ * @return Optional error string, should be present if validation resulted
in an error
Review Comment:
iff -> if, unnecessary change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
