wangyang0918 commented on code in PR #141:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/141#discussion_r843951495
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/FlinkResourceValidator.java:
##########
@@ -17,18 +17,19 @@
package org.apache.flink.kubernetes.operator.validation;
+import org.apache.flink.core.plugin.Plugin;
import org.apache.flink.kubernetes.operator.crd.FlinkDeployment;
import org.apache.flink.kubernetes.operator.crd.FlinkSessionJob;
import java.util.Optional;
/** Validator for different resources. */
-public interface FlinkResourceValidator {
+public interface FlinkResourceValidator extends Plugin {
Review Comment:
I am not sure whether we need to introduce the
`FlinkResourceValidatorFactory`, which actually extends the `Plugin` interface.
The advantage is we do not need a default constructor for
`FlinkResourceValidator`.
Another thing is we might not need to extend `Plugin` interface since we do
not call `#configure()`. If some users implement the `#configure()`, it could
not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
