rkhachatryan commented on code in PR #19331:
URL: https://github.com/apache/flink/pull/19331#discussion_r843848500
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java:
##########
@@ -174,6 +181,20 @@ public void registerAll(
}
}
+ @Override
+ public void registerAllAfterRestored(CompletedCheckpoint checkpoint,
RestoreMode mode) {
Review Comment:
Because a single completed checkpoint should not be aware of the
`highestRetainCheckpointID`; `SharedStateRegistry` would have to have a
separate method to update `highestRetainCheckpointID`.
IMO, that would make the code less readable and more error-prone.
I'm also not sure whether `SharedStateRegistry` should be aware of the
restore mode or not;
But given that there are no obvious reasons against it, and taking the above
into account, I'd stick with the current approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
