rkhachatryan commented on code in PR #19331:
URL: https://github.com/apache/flink/pull/19331#discussion_r844873630
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java:
##########
@@ -174,6 +181,20 @@ public void registerAll(
}
}
+ @Override
+ public void registerAllAfterRestored(CompletedCheckpoint checkpoint,
RestoreMode mode) {
Review Comment:
Thanks for clarifying. Indeed, a separate method would not be needed with
this approach. But now the logic inside `CompletedCheckpoint` will be tricky
IMO: `registry.registerAll(..., mode == CLAIM ? -1 : this.id`. So I think I'll
keep the logic in place in `SharedStateRegistry` for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
