Myasuka commented on code in PR #19331:
URL: https://github.com/apache/flink/pull/19331#discussion_r843906333
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistry.java:
##########
@@ -32,11 +33,11 @@
/** A singleton object for the default implementation of a {@link
SharedStateRegistryFactory} */
SharedStateRegistryFactory DEFAULT_FACTORY =
- (deleteExecutor, checkpoints) -> {
+ (deleteExecutor, checkpoints, restoreMode) -> {
SharedStateRegistry sharedStateRegistry =
new SharedStateRegistryImpl(deleteExecutor);
for (CompletedCheckpoint checkpoint : checkpoints) {
-
checkpoint.registerSharedStatesAfterRestored(sharedStateRegistry);
+
checkpoint.registerSharedStatesAfterRestored(sharedStateRegistry, restoreMode);
Review Comment:
What I mean is that if we restore from chk-10 with `NO_CLAIM` mode, and then
the JM crashed on chk-20, will the chk-20 also be treated as the not-claimed
checkpoint, leading to the chk-20 never be discarded anymore. If so, does this
make orphan checkpoints left?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
