Myasuka commented on code in PR #19331:
URL: https://github.com/apache/flink/pull/19331#discussion_r845767465
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/EmbeddedCompletedCheckpointStore.java:
##########
@@ -62,7 +63,7 @@ public EmbeddedCompletedCheckpointStore(
maxRetainedCheckpoints,
initialCheckpoints,
SharedStateRegistry.DEFAULT_FACTORY.create(
- Executors.directExecutor(), initialCheckpoints));
+ Executors.directExecutor(), initialCheckpoints,
RestoreMode.DEFAULT));
Review Comment:
If we changed the default restore mode to `CLAIM`, can we also keep this
here?
From my understanding, we use `NO_CLAIM` mode for the safety to not discard
checkpoint.
And if we just want to make the safety, I think this deserves a description
and maybe we need to refer to FLINK-27114.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
