yunfengzhou-hub commented on code in PR #82: URL: https://github.com/apache/flink-ml/pull/82#discussion_r846882100
########## flink-ml-core/src/main/java/org/apache/flink/ml/param/ArrayArrayParam.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.param; + +import org.apache.flink.ml.util.ReadWriteUtils; + +import java.io.IOException; + +/** Class for the arrayOfArray-type parameters. */ +public class ArrayArrayParam<T> extends Param<T[][]> { Review Comment: I agree with it that on API we need to display getter/setter for 2D arrays, but as for internal implementation, I believe we can store the 2D array in a 1D format. This does not affect user experience and can reuse existing `ArrayParams`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
