yunfengzhou-hub commented on code in PR #82:
URL: https://github.com/apache/flink-ml/pull/82#discussion_r846882710
##########
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/onehotencoder/OneHotEncoderParams.java:
##########
@@ -27,6 +27,8 @@
/**
* Params of OneHotEncoderModel.
*
+ * <p>The `keep` option of {@link HasHandleInvalid} is not supported in {@link
OneHotEncoderParams}.
Review Comment:
I think it could be better if we make the JavaDoc correspond to the actual
behavior. We can modify the JavaDoc when we add support for `SKIP` in future.
Thus it might be better to comment that `OneHotEncoder` only supports `ERROR`
in its JavaDoc for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
