infoverload commented on code in PR #19414:
URL: https://github.com/apache/flink/pull/19414#discussion_r847355828
##########
flink-end-to-end-tests/flink-stream-stateful-job-upgrade-test/src/main/java/org/apache/flink/streaming/tests/StatefulStreamJobUpgradeTestProgram.java:
##########
@@ -90,11 +92,13 @@ public static void main(String[] args) throws Exception {
private static void executeOriginalVariant(StreamExecutionEnvironment env,
ParameterTool pt)
throws Exception {
+ Duration maxOutOfOrderness = extractTimestamp(pt);
KeyedStream<Event, Integer> source =
env.addSource(createEventSource(pt))
.name("EventSource")
.uid("EventSource")
-
.assignTimestampsAndWatermarks(createTimestampExtractor(pt))
+ .assignTimestampsAndWatermarks(
+
WatermarkStrategy.forBoundedOutOfOrderness(maxOutOfOrderness))
Review Comment:
Are you sure? Because the `Duration maxOutOfOrderness =
extractTimestamp(pt);` above already has the timestamp
##########
flink-end-to-end-tests/flink-stream-stateful-job-upgrade-test/src/main/java/org/apache/flink/streaming/tests/StatefulStreamJobUpgradeTestProgram.java:
##########
@@ -90,11 +92,13 @@ public static void main(String[] args) throws Exception {
private static void executeOriginalVariant(StreamExecutionEnvironment env,
ParameterTool pt)
throws Exception {
+ Duration maxOutOfOrderness = extractTimestamp(pt);
KeyedStream<Event, Integer> source =
env.addSource(createEventSource(pt))
.name("EventSource")
.uid("EventSource")
-
.assignTimestampsAndWatermarks(createTimestampExtractor(pt))
+ .assignTimestampsAndWatermarks(
+
WatermarkStrategy.forBoundedOutOfOrderness(maxOutOfOrderness))
Review Comment:
Are you sure? Because the `Duration maxOutOfOrderness =
extractTimestamp(pt)` above already has the timestamp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
