lindong28 commented on code in PR #82: URL: https://github.com/apache/flink-ml/pull/82#discussion_r849347711
########## flink-ml-core/src/main/java/org/apache/flink/ml/param/ArrayArrayParam.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.param; + +import org.apache.flink.ml.util.ReadWriteUtils; + +import java.io.IOException; + +/** Class for the arrayOfArray-type parameters. */ Review Comment: nits: it is rare to use `arrayOfArray` in comments. How about `Class for the array parameters`, which seems to be more consistent with the comments of most XXXParam classes. And how about we change the comment of `ArrayParam` to `Class for the array parameters` for consistency? ########## flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasHandleInvalid.java: ########## @@ -32,18 +32,21 @@ * <ul> * <li>error: raise an exception. * <li>skip: filter out rows with bad values. + * <li>keep: keep bad rows according to a specific rule. Check out each algorithm for detail Review Comment: nits: `for detail rule` does not seem readable. How about `for details`? ########## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/onehotencoder/OneHotEncoderParams.java: ########## @@ -27,6 +27,9 @@ /** * Params of OneHotEncoderModel. * + * <p>The `keep` and `skip` option of {@link HasHandleInvalid} is not supported in {@link Review Comment: Most users will checkout the Java doc of the stage classes instead of the XXXParam classes, such as `OneHotEncoder` and `OneHotEncoderModel`, to understand how to use these algorithms. Would it be more user-friendly to move this explanation to the Java doc of `OneHotEncoder` and `OneHotEncoderModel`? Same for other algorithms. ########## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/bucketizer/Bucketizer.java: ########## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.feature.bucketizer; + +import org.apache.flink.api.common.functions.FlatMapFunction; +import org.apache.flink.api.common.typeinfo.BasicTypeInfo; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.api.java.typeutils.RowTypeInfo; +import org.apache.flink.ml.api.Transformer; +import org.apache.flink.ml.common.datastream.TableUtils; +import org.apache.flink.ml.param.Param; +import org.apache.flink.ml.util.ParamUtils; +import org.apache.flink.ml.util.ReadWriteUtils; +import org.apache.flink.streaming.api.datastream.DataStream; +import org.apache.flink.table.api.Table; +import org.apache.flink.table.api.bridge.java.StreamTableEnvironment; +import org.apache.flink.table.api.internal.TableImpl; +import org.apache.flink.types.Row; +import org.apache.flink.util.Collector; +import org.apache.flink.util.Preconditions; + +import org.apache.commons.lang3.ArrayUtils; + +import java.io.IOException; +import java.util.Arrays; +import java.util.HashMap; +import java.util.Map; + +/** + * Bucketizer is a transformer that maps multiple columns of continuous features to multiple columns + * of discrete features, i.e., buckets IDs. Review Comment: Would it be useful to replace `buckets IDs` with `bucket indices`, and mention that `the indices are in [0, numSplitsInThisColumn - 1]`, to provide more information regarding the output of this class? This would also make the comment more consistent with that of `StringIndexer`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
