zhipeng93 commented on code in PR #82:
URL: https://github.com/apache/flink-ml/pull/82#discussion_r850118629
##########
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/onehotencoder/OneHotEncoderParams.java:
##########
@@ -27,6 +27,9 @@
/**
* Params of OneHotEncoderModel.
*
+ * <p>The `keep` and `skip` option of {@link HasHandleInvalid} is not
supported in {@link
Review Comment:
Thanks for the comment. I prefer putting the description in XXXParam class
for the following two reaons:
- Putting the description to concrete classes may lead to duplicate
comments. For example, `OneHotEncoder` and `OneHotEncoderModel`.
- I don't really think checking Java doc for XXXParams is a
bad/not-user-friendly behavior. They are public interfaces by the way. For
documents on FlinkML website, we can put all Java docs related to a certain
algorithm together.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
