gyfora commented on code in PR #165:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r850314090
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -261,7 +261,7 @@ private Optional<String> validateSpecChange(FlinkDeployment
deployment) {
&& deployment.getStatus().getJobManagerDeploymentStatus()
!= JobManagerDeploymentStatus.MISSING
&&
ReconciliationUtils.isUpgradeModeChangedToLastStateAndHADisabledPreviously(
- deployment)) {
+ deployment, new Configuration())) {
Review Comment:
Good catch, The only reason I have this here because I am waiting for this
PR to be completed by @SteNicholas :
https://github.com/apache/flink-kubernetes-operator/pull/162
I didnt want to double implement the logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
