gyfora commented on code in PR #165:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r850340211
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java:
##########
@@ -159,16 +185,16 @@ private void checkCrashLoopBackoff(FlinkDeployment
flinkApp, Configuration effec
}
}
- protected boolean isClusterReady(FlinkDeployment dep) {
+ protected boolean isJmDeploymentReady(FlinkDeployment dep) {
return dep.getStatus().getJobManagerDeploymentStatus() ==
JobManagerDeploymentStatus.READY;
}
- protected void
clearErrorsIfJobManagerDeploymentNotInErrorStatus(FlinkDeployment dep) {
- if (dep.getStatus().getJobManagerDeploymentStatus() !=
JobManagerDeploymentStatus.ERROR) {
- final ReconciliationStatus reconciliationStatus =
- dep.getStatus().getReconciliationStatus();
- reconciliationStatus.setSuccess(true);
- reconciliationStatus.setError(null);
+ protected void clearErrorsIfDeploymentIsHealthy(FlinkDeployment dep) {
Review Comment:
Well it's both stable and no errors thats why I went for healthy instead :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
