gyfora commented on code in PR #162:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/162#discussion_r851798061
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkUtils.java:
##########
@@ -61,6 +61,18 @@ public static DefaultConfig loadDefaultConfig() {
return new DefaultConfig(operatorConfig, flinkConfig);
}
+ public static Configuration getFlinkEffectiveConfig(FlinkDeployment
flinkApp) {
+ try {
+ final Configuration effectiveConfig =
+ FlinkConfigBuilder.buildFlinkFrom(
+ flinkApp,
loadConfiguration(EnvUtils.get(EnvUtils.ENV_FLINK_CONF_DIR)));
Review Comment:
We should avoid loading the configuration again and again. Best would be to
only do it once here or in the validtor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
