gyfora commented on code in PR #162:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/162#discussion_r851798624
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -58,6 +58,8 @@ public class DefaultValidator implements
FlinkResourceValidator {
@Override
public Optional<String> validateDeployment(FlinkDeployment deployment) {
FlinkDeploymentSpec spec = deployment.getSpec();
+ Map<String, String> effectiveConfig =
+ FlinkUtils.getFlinkEffectiveConfig(deployment).toMap();
Review Comment:
I think this is still incorrect from a validation perspective ,we should
simply make a copy from the default config and put all values.:
```
Configuration conf = new Configuration(defaultConf)
conf.putAll(spec.getFlinkConfiguration)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
