wangyang0918 commented on code in PR #173:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/173#discussion_r853706739
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/FlinkOperatorITCase.java:
##########
@@ -114,6 +114,7 @@ private static FlinkDeployment buildSessionCluster() {
resource.setCpu(1);
JobManagerSpec jm = new JobManagerSpec();
jm.setResource(resource);
+ jm.setReplicas(1);
Review Comment:
Yes. I believe the `replicas` is not a field which should be configured
explicitly. In most cases, no matter the HA enabled or not, they do not need to
set this. Unless they really want a standby JobManager to get faster recovery.
Maybe we could also remove the `replicas` in the examples and `e2e-tests`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
