bgeng777 commented on code in PR #173:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/173#discussion_r853721497
##########
.github/workflows/ci.yml:
##########
@@ -73,7 +73,7 @@ jobs:
- name: Tests in flink-kubernetes-operator
run: |
cd flink-kubernetes-operator
- mvn integration-test -Dit.skip=false
+ mvn verify -Dit.skip=false
Review Comment:
You are right. In the root pom, we only declare `integration-test` goal for
`maven-failsafe-plugin` while not adding `verify` goal. As a result, `mvn
verify` phase will not execute the `maven-failsafe-plugin:verify`, which makes
the build will succeed even when the IT case fails. I have fixed this, the
execution of ITCase can be found
[here](https://pipelines.actions.githubusercontent.com/serviceHosts/a2c2e851-e8cc-4b87-8abf-a33c133702e9/_apis/pipelines/1/runs/1067/signedlogcontent/2?urlExpires=2022-04-20T04%3A45%3A40.8735995Z&urlSigningMethod=HMACV1&urlSignature=RcXN8qsKPyeGLWBCOCUK9PAi6htDzAb2NQG47FUxpmY%3D).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
