rkhachatryan commented on code in PR #19448:
URL: https://github.com/apache/flink/pull/19448#discussion_r853979792
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultExecutionGraphFactory.java:
##########
@@ -203,10 +204,15 @@ private void tryRestoreExecutionGraphFromSavepoint(
final CheckpointCoordinator checkpointCoordinator =
executionGraphToRestore.getCheckpointCoordinator();
if (checkpointCoordinator != null) {
+ Optional<String> stateBackendName =
executionGraphToRestore.getStateBackendName();
+ boolean changelogEnabled =
+ stateBackendName.isPresent()
+ &&
"ChangelogStateBackend".equals(stateBackendName.get());
Review Comment:
I'm not sure whether it's always possible to infer whether the changelog is
enabled or not from `executionGraphToRestore.getStateBackendName()`.
In particular, will this work if `flink-conf.yaml` contains
`state.backend.changelog.enabled=true` and job doesn't specify changelog or
even any backend?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
