rkhachatryan commented on code in PR #19448:
URL: https://github.com/apache/flink/pull/19448#discussion_r854122607
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultExecutionGraphFactory.java:
##########
@@ -203,10 +204,15 @@ private void tryRestoreExecutionGraphFromSavepoint(
final CheckpointCoordinator checkpointCoordinator =
executionGraphToRestore.getCheckpointCoordinator();
if (checkpointCoordinator != null) {
+ Optional<String> stateBackendName =
executionGraphToRestore.getStateBackendName();
+ boolean changelogEnabled =
+ stateBackendName.isPresent()
+ &&
"ChangelogStateBackend".equals(stateBackendName.get());
Review Comment:
Thanks for verifying. Indeed, the whole config is currently available to the
JM.
However, I'm not sure whether we should rely on it because:
1. TMs can still have different configuration (I'm not sure whether it's a
theoretical situation or not).
2. Configuration is called `jobMasterConfiguration`; which means it doesn't
have to be the whole configuration.
So far we tried to not rely on it IIRC.
We probably don't need to make this decision now, before deciding which
approach to take.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
