GezimSejdiu commented on PR #170: URL: https://github.com/apache/flink-kubernetes-operator/pull/170#issuecomment-1104478327
> > @GezimSejdiu Thanks for your explanation. I still have some questions before we could merge this PR. > > * IIUC, we need to create a `gh-pages`, which will store the published charts. Yes, if we do not want to host them into https://downloads.apache.org/flink/ then in order for the releaser to work it needs a site where it can also write the index file and store the published charts. Please, do let me know if you are going to create it as we also need to adapt/change the way this workflow works e.g. remove [chart_repo_url](https://github.com/apache/flink-kubernetes-operator/pull/170/commits/621303887b323cfac53ed6f95b2959298a0d894c#diff-4e6486e1da78f83d1007495745cc4bb5a27de1d2664d652564ab193d6634a81fR31). > * I am not sure whether this PR could work when some changes happen in `helm/flink-kubernetes-operator` while the version(1.0-SNAPSHOT) does not change. Right, the generated release is based on: ``` --release-name-template string Go template for computing release names, using chart metadata (default "{{ .Name }}-{{ .Version }}") ``` and thus will check if the same version/release does exists. The idea here is that `main` is considered as a proper release when you push changes to the chart -- it needs a release. A workaround is to use: ``` --skip-existing Skip upload if release exists ``` but then it will not serve the purpose of "SNAPSHOTING" -- so not sure how to handle this. Maybe we can ask the community at https://github.com/helm/chart-releaser to be able to allow `--override or similar? > * We might need to enrich the [quick start](https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/try-flink-kubernetes-operator/quick-start/) to document how to use helm chart snapshot release. Yes, asap as this is pushed and we want to use it -- we will also have to update the guide on how to use the snapshot (e.g. I wanted to use it here: https://seatunnel.apache.org/docs/start/kubernetes -- to test the new version but wasn't able to pull it :( (of course installing it locally can also work). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
