GezimSejdiu commented on PR #170: URL: https://github.com/apache/flink-kubernetes-operator/pull/170#issuecomment-1103135999
Hey @wangyang0918, thanks a lot for your review on this. Reg.: > * `https://downloads.apache.org/flink/` is not a right place to host the snapshot helm chart release. Only the released version could be found there. So I think we need to publish the snapshot helm charts via github packages. Right, I wasn't aware of that and thus I will update to only be released within github-pages as https://github.com/helm/chart-releaser#chart-releaser point out if we do not want to host them elsewhere. For that to be possible we will need to have gh-pages branch (as pointed here: https://github.com/helm/chart-releaser-action#pre-requisites, point 2 and 3). Um, reg. `github-packages` -- this Github Actions do not publish them as Github Package but rather as a normal Releases (see here as an example: https://github.com/GezimSejdiu/flink-kubernetes-operator/releases and in order this release be usable -- it has to also be hosted somewhere e.g. gh-pages is the default one used from the plugin but it also provides alternatives (as I was trying to do it so that we publish that into flink. downloads). > * I expect only when some changes happen in `helm/flink-kubernetes-operator`, then it needs to publish the helm charts again. Other java code changes should not trigger this. Yes, that is true. It only triggers when anything has been changed into `helm` folder e..g there may be another helm chart (take `flink-job-deployment` -- creating Flink Job Deployment within Helm Charts). Let me know if: - we are going to use Github Pages as a hosting platform for the helm-chart (SNAPSHOT) so that we can also use it for fast prototying/testing? -- by that I can already remove the `charts_repo_url: https://downloads.apache.org/flink/` which then will opt in to use the default one `gh-pages`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
