gyfora commented on code in PR #176:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/176#discussion_r856146587
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/status/ReconciliationStatus.java:
##########
@@ -54,19 +49,20 @@ public class ReconciliationStatus {
private ReconciliationState state = ReconciliationState.DEPLOYED;
@JsonIgnore
- public FlinkDeploymentSpec deserializeLastReconciledSpec() {
- return ReconciliationUtils.deserializedSpecWithVersion(
- lastReconciledSpec, FlinkDeploymentSpec.class);
+ public abstract Class<SPEC> getSpecClass();
Review Comment:
You could also simply add a constructor that takes the spec class (you have
that when you call initStatus by calling getSpec().getClass()). Then you would
not need 2 subclasses just to implement this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
