Aitozi commented on code in PR #176:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/176#discussion_r856933715
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/status/ReconciliationStatus.java:
##########
@@ -54,19 +49,20 @@ public class ReconciliationStatus {
private ReconciliationState state = ReconciliationState.DEPLOYED;
@JsonIgnore
- public FlinkDeploymentSpec deserializeLastReconciledSpec() {
- return ReconciliationUtils.deserializedSpecWithVersion(
- lastReconciledSpec, FlinkDeploymentSpec.class);
+ public abstract Class<SPEC> getSpecClass();
Review Comment:
I have tried this way, But if I add a field to record the spec class in
`ReconciliationStatus` (making it `@JsonIgnore` ), It will cause the
[CRDGenerator stack overflow
](https://github.com/fabric8io/kubernetes-client/issues/4092). So I kept it as
it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
