twalthr commented on code in PR #19566:
URL: https://github.com/apache/flink/pull/19566#discussion_r857350481
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/rules/logical/RemoveUnreachableCoalesceArgumentsRuleTest.java:
##########
@@ -83,4 +83,27 @@ public void testJoinCoalesce() {
util.verifyRelPlan(
"SELECT * FROM T t1 LEFT JOIN T t2 ON COALESCE(t1.f0, '-',
t1.f2) = t2.f0");
}
+
+ @Test
+ public void testMultipleCoalesces() {
Review Comment:
This test is not super helpful as it is unable to test to final result type.
Can you add at least a single test to `CoalesceFunctionITCase`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
