snuyanzin commented on PR #19565:
URL: https://github.com/apache/flink/pull/19565#issuecomment-1108636404
LGTM from my side
the only neat question I have:
does it make sense to add a test for case with no integer part like
```java
.fromCase(
STRING(),
fromString(" .1 "),
fromBigDecimal(new BigDecimal("0.100"), 5,
3))
```
postgres also supports that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
