yunfengzhou-hub commented on code in PR #90:
URL: https://github.com/apache/flink-ml/pull/90#discussion_r858230044
##########
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/logisticregression/LogisticRegressionModel.java:
##########
@@ -18,51 +18,28 @@
package org.apache.flink.ml.classification.logisticregression;
-import org.apache.flink.api.common.functions.RichMapFunction;
import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
import org.apache.flink.api.common.typeinfo.TypeInformation;
-import org.apache.flink.api.java.tuple.Tuple2;
import org.apache.flink.api.java.typeutils.RowTypeInfo;
-import org.apache.flink.ml.api.Model;
-import org.apache.flink.ml.common.broadcast.BroadcastUtils;
-import org.apache.flink.ml.common.datastream.TableUtils;
+import org.apache.flink.ml.common.glm.GeneralLinearAlgoModel;
import org.apache.flink.ml.linalg.BLAS;
import org.apache.flink.ml.linalg.DenseVector;
import org.apache.flink.ml.linalg.Vectors;
-import org.apache.flink.ml.param.Param;
-import org.apache.flink.ml.util.ParamUtils;
import org.apache.flink.ml.util.ReadWriteUtils;
-import org.apache.flink.streaming.api.datastream.DataStream;
import org.apache.flink.table.api.Table;
import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
-import org.apache.flink.table.api.internal.TableImpl;
import org.apache.flink.types.Row;
-import org.apache.flink.util.Preconditions;
import org.apache.commons.lang3.ArrayUtils;
import java.io.IOException;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.Map;
+import java.io.Serializable;
-/** A Model which classifies data using the model data computed by {@link
LogisticRegression}. */
-public class LogisticRegressionModel
- implements Model<LogisticRegressionModel>,
- LogisticRegressionModelParams<LogisticRegressionModel> {
-
- private final Map<Param<?>, Object> paramMap = new HashMap<>();
-
- private Table modelDataTable;
-
- public LogisticRegressionModel() {
- ParamUtils.initializeMapWithDefaultValues(paramMap, this);
- }
-
- @Override
- public Map<Param<?>, Object> getParamMap() {
- return paramMap;
- }
+/**
+ * A Model which classifies the input using the model data computed by {@link
LogisticRegression}.
+ */
+public class LogisticRegressionModel extends
GeneralLinearAlgoModel<LogisticRegressionModel>
+ implements LogisticRegressionModelParams<LogisticRegressionModel>,
Serializable {
@Override
public void save(String path) throws IOException {
Review Comment:
If the change described for ModelData classes is feasible, then methods like
`LogisticRegressionModel.save()` and `LogisticRegression.createModel()` might
also be moved to corresponding abstract classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
