zhipeng93 commented on code in PR #90:
URL: https://github.com/apache/flink-ml/pull/90#discussion_r858419504
##########
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/logisticregression/LogisticRegressionModelData.java:
##########
@@ -42,12 +43,9 @@
* <p>This class also provides methods to convert model data from Table to
Datastream, and classes
* to save/load model data.
*/
-public class LogisticRegressionModelData {
-
- public DenseVector coefficient;
-
+public class LogisticRegressionModelData extends GeneralLinearAlgoModelData {
Review Comment:
I also tried to do this but failed because in `ModelDataEncoder` we need to
construct an instance of `LinearRegressionModelData` and
`LogisticRegressionModelData `. If we pass a class type, we may need to go with
reflections, which is usually not encouraged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
