lsyldliu commented on code in PR #19419:
URL: https://github.com/apache/flink/pull/19419#discussion_r858258708
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/AlterTableDropConstraintOperation.java:
##########
@@ -20,24 +20,42 @@
import org.apache.flink.table.catalog.ObjectIdentifier;
+import javax.annotation.Nullable;
+
+import java.util.Optional;
+
/** Operation of "ALTER TABLE ADD [CONSTRAINT constraintName] ..." clause. * */
public class AlterTableDropConstraintOperation extends AlterTableOperation {
- private final String constraintName;
+
+ private final boolean isPrimaryKey;
+ private final @Nullable String constraintName;
public AlterTableDropConstraintOperation(
- ObjectIdentifier tableIdentifier, String constraintName) {
+ ObjectIdentifier tableIdentifier,
+ boolean isPrimaryKey,
Review Comment:
I think it is not needed, here only two variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
