XComp commented on code in PR #19528: URL: https://github.com/apache/flink/pull/19528#discussion_r858687044
########## tools/ci/stage.sh: ########## @@ -21,8 +21,8 @@ STAGE_COMPILE="compile" STAGE_CORE="core" STAGE_PYTHON="python" STAGE_TABLE="table" -STAGE_CONNECTORS="connectors" -STAGE_KAFKA_GELLY="kafka/gelly" +STAGE_CONNECTORS_1="connectors_1" +STAGE_CONNECTORS_2="connectors_2" Review Comment: I don't like how these two stages have a common prefix. In AzureCI, the end of the name is sometimes cut of leaving both stages with the same label + "..." as a prefix. Can't we come up with something more descriptive? ########## tools/ci/stage.sh: ########## @@ -48,11 +52,23 @@ flink-metrics,\ flink-metrics/flink-metrics-core,\ flink-external-resources,\ flink-external-resources/flink-external-resource-gpu,\ +flink-libraries,\ flink-libraries/flink-cep,\ flink-libraries/flink-cep-scala,\ -flink-libraries/flink-state-processing-api" +flink-libraries/flink-state-processing-api,\ +flink-libraries/flink-gelly,\ +flink-libraries/flink-gelly-scala,\ +flink-libraries/flink-gelly-examples,\ +flink-queryable-state,\ +flink-queryable-state/flink-queryable-state-runtime,\ +flink-queryable-state/flink-queryable-state-client-java,\ +flink-container,\ +flink-dstl,\ +flink-dstl/flink-dstl-dfs,\ Review Comment: The succeeding commas seem to be fine for `mvn -pl` on the modules. But negating a list like `flink-core,` will result in something like `mvn -pl !flink-core,!` will cause the maven call to fail... It fails on my local machine (MacOS) at least: ``` $ mvn -pl flink-core,!,!flink-runtime spotless:apply zsh: event not found: ,! ``` Interestingly, the [AzureCI run](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=34881&view=logs&j=fc5181b0-e452-5c8f-68de-1097947f6483&t=995c650b-6573-581c-9ce6-7ad4cc038461&l=23160) succeeds with a module definition like `[...]!flink-dstl,!flink-dstl/flink-dstl-dfs,!,!flink-table[...]` being in place. Maybe, a OS issue? We might want to fix it anyway... ########## tools/ci/stage.sh: ########## @@ -48,11 +52,23 @@ flink-metrics,\ flink-metrics/flink-metrics-core,\ flink-external-resources,\ flink-external-resources/flink-external-resource-gpu,\ +flink-libraries,\ flink-libraries/flink-cep,\ flink-libraries/flink-cep-scala,\ -flink-libraries/flink-state-processing-api" +flink-libraries/flink-state-processing-api,\ +flink-libraries/flink-gelly,\ +flink-libraries/flink-gelly-scala,\ +flink-libraries/flink-gelly-examples,\ +flink-queryable-state,\ +flink-queryable-state/flink-queryable-state-runtime,\ +flink-queryable-state/flink-queryable-state-client-java,\ +flink-container,\ +flink-dstl,\ +flink-dstl/flink-dstl-dfs,\ Review Comment: FYI: This is not the only location with this error. I was just too lazy to mark all of them 😇 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
