zentol commented on code in PR #19528: URL: https://github.com/apache/flink/pull/19528#discussion_r858719635
########## tools/ci/stage.sh: ########## @@ -21,8 +21,8 @@ STAGE_COMPILE="compile" STAGE_CORE="core" STAGE_PYTHON="python" STAGE_TABLE="table" -STAGE_CONNECTORS="connectors" -STAGE_KAFKA_GELLY="kafka/gelly" +STAGE_CONNECTORS_1="connectors_1" +STAGE_CONNECTORS_2="connectors_2" Review Comment: any suggestions? there isn't a particular pattern (apart from formats/reporters/filesystems being in connector_1), and I'm not keen on a naming scheme that includes specific modules (e.g., "kafka/pulsar") as I'm not looking forward to renaming stuff when we externalize more stuff. Ultimately the lifetime of these stages is limited anyway; until the connectors have been externalized, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
